Skip to content

Adding OSAL inotify - #379

Open
MaciejKaszynski wants to merge 7 commits into
eclipse-score:mainfrom
etas-contrib:create-wait-for-osal
Open

Adding OSAL inotify#379
MaciejKaszynski wants to merge 7 commits into
eclipse-score:mainfrom
etas-contrib:create-wait-for-osal

Conversation

@MaciejKaszynski

@MaciejKaszynski MaciejKaszynski commented Jul 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Adding a small wrapper around score::os::InotifyInstance to get iterator syntax.

Usage:

    auto instance = std::make_unique<score::os::InotifyInstanceImpl>();
    instance.AddWatch("/tmp", score::os::Inotify::EventMask::kInCreate);

    for (const score::os::InotifyEvent& event : INotifyRange{std::move(instance)})
    {
        // will block until a new event is present
        // running touch /tmp/test will print test!
        std::cout << event.GetName() << std::endl;
    };

@github-actions

github-actions Bot commented Jul 28, 2026 •
edited
Loading

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output 
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 4e3511e9-f6ee-4068-a561-4f3519d0dcf1
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (35 packages loaded, 10 targets configured)

Analyzing: target //:license-check (87 packages loaded, 10 targets configured)

Analyzing: target //:license-check (143 packages loaded, 427 targets configured)

Analyzing: target //:license-check (158 packages loaded, 4127 targets configured)

Analyzing: target //:license-check (158 packages loaded, 9130 targets configured)

Analyzing: target //:license-check (167 packages loaded, 9367 targets configured)

Analyzing: target //:license-check (170 packages loaded, 9397 targets configured)

Analyzing: target //:license-check (170 packages loaded, 9397 targets configured)

Analyzing: target //:license-check (170 packages loaded, 9397 targets configured)

Analyzing: target //:license-check (173 packages loaded, 11285 targets configured)

Analyzing: target //:license-check (174 packages loaded, 11409 targets configured)

Analyzing: target //:license-check (174 packages loaded, 11409 targets configured)

INFO: Analyzed target //:license-check (175 packages loaded, 11535 targets configured).
[12 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox ... (2 actions, 1 running)
[15 / 16] [Prepa] Building license.check.license_check.jar ()
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 29.679s, Critical Path: 2.56s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

MaciejKaszynski
MaciejKaszynski commented Jul 29, 2026
View reviewed changes
Comment thread score/launch_manager/src/daemon/src/osal/details/posix/inotify_iterator.cpp Outdated
SimonKozik
SimonKozik reviewed Jul 29, 2026
View reviewed changes
Comment thread score/launch_manager/src/daemon/src/osal/details/posix/inotify_iterator.cpp Outdated
Comment thread score/launch_manager/src/daemon/src/osal/details/posix/inotify_iterator.cpp Outdated
@MaciejKaszynski
MaciejKaszynski marked this pull request as ready for review July 31, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NicolasFussberger NicolasFussberger Awaiting requested review from NicolasFussberger NicolasFussberger is a code owner
@pawelrutkaq pawelrutkaq Awaiting requested review from pawelrutkaq pawelrutkaq is a code owner
@ramceb ramceb Awaiting requested review from ramceb ramceb is a code owner
@FScholPer FScholPer Awaiting requested review from FScholPer FScholPer is a code owner
@antonkri antonkri Awaiting requested review from antonkri antonkri is a code owner
@anmittag anmittag Awaiting requested review from anmittag anmittag is a code owner
1 more reviewer
@SimonKozik SimonKozik SimonKozik left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@MaciejKaszynski MaciejKaszynski

Labels

None yet

Projects

LCM - Lifecycle & Health FT
Status: Backlog

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MaciejKaszynski @SimonKozik